Apologies if this (or something similar) has been brought up. I took a quick look through the topic headers and didn't find anything.
I've had a compatibility bug report to my "Infinite Resources - Normal Yields" mod with this mod, that being that my mod is not affecting resources added by Nullius. A quick look suggests that this may be a conflict of mod load order in combination of when this mod adds its resources.
Unless there are specific reasons for doing things the way you have, may I make some suggestions?
- Your new resources should probably be defined in data.lua (instead of data-updates.lua). This will allow mods that then iterate through all of the resources in data-updates.lua to be able to grab yours, too, without the need of pushing this off to data-final-fixes.lua (where some other changes may be necessitated at) or adding your mod as an optional dependency (to guarantee load order). This same concept applies to any newly added items, entities, etc as well.
-
Your changes to vanilla resources (or any other vanilla item you may modify and keep in a similar manner), while it's fine being done in data-updates.lua, should probably be done by modifying only those properties that you need to change for your mod instead of redefining the entire thing and then overwriting the original. This will allow other mods to make changes to properties that your mod doesn't touch or care about (like say the icon or sprite sheet) without risk of being overwritten. For example, the main thing I see you modifying on iron ore is the mining time. This could be accomplished with this one line of code:
data.raw.resource["iron-ore"].minable.mining_time = 1.2
I just wanted to bring these to your attention. It would certainly help to increase compatibility between mods. :)
(Edited for formatting; I hate markdown :( )