(Edit: Sorry about title, meant to elaborate in title more but forgot before hitting post. Can't' update afterward)

Hey! Got a crash when using this mod

The mod Planet picker (1.1.5) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event planet-picker::on_player_created (ID 32)
An error occured while compiling "entity:coal:probability" noise expression:
VariablePersistenceMultioctaveNoise::offset_x can't be infinite
stack traceback:
    [C]: in function 'create_surface'
    __planet-picker__/script/planet-select.lua:233: in function 'enable_planet'
    __planet-picker__/script/planet-select.lua:165: in function 'add_planet'
    __planet-picker__/script/planet-select.lua:214: in function 'reload_planets'
    __planet-picker__/utils.lua:253: in function 'setup_storage'
    __planet-picker__/control.lua:45: in function <__planet-picker__/control.lua:38>

It might be an incompatibility with the "Solar Systems" modded planets, but I'm not 100% sure. It happens when the "auto detect other planets" option is picked.

I've looked into the Solar Systems mod and it appears to be rather tightly integrated into the Any Planet Start mod, even specifying it directly as a prerequisite.

Planet Picker and Any Planet Start are not technically incompatible, but they really aren't meant to be used together. APS sets the starter planet for all players and changes a lot of things in the data phase, whereas Planet Picker performs most of its work at the runtime phase allowing each player to pick different planets rather than starting together. Because of this, the APS integration can do things like alter the prototypes of the planet you start on, which I believe is the problem here.

It looks like the surface settings for the planets from the Solar Systems mods are misconfigured until the mod itself spawns the surface, and since Planet Picker needs to ensure the surface you're starting on is generated before previewing and spawning, the invalid surface configs cause the crash.

I tried disabling the preview stuff temporarily to see if you could still spawn on the planet, thinking it might be possible to avoid this problem by gating the preview feature behind a setting, but it still wasn't happy. I'm not entirely sure what they're doing with their surface configs or why it ever has to be invalid, but it seems to be a fundamental incompatibility between how they're setting up their planets and how Planet Picker necessarily has to interact with them.

Ideally the planets' surface configurations would always be valid, and APS would not be a mandatory dependency. Not much I can do from my mod without writing a lot of compatibility code specifically for these mods that will have a performance impact, might cause issues with other mods, and will likely break the moment they make any changes to the surface configs.

I'll contact the other mod author then, see if they can make their planet mods to not require APS (theoretically they shouldn't need it anyways) or fork their planet mods if need be and see if I can do it myself (last resort but possibly do-able). I really like the idea of this mod (picking any planet) for a multiplayer server with a bunch of worlds in it.

It looks like Solar System++ by rjdunlap is the mod that's pulling in APS as required, which in turn is requried by all the planets.

Might be a bit of an ask, doesn't look like they've been active for 11+ months but it can't hurt to ask around.

Theoretically they just need to make sure their planet surface definitions are valid whenever other mods like Planet Picker try to trigger their surfaces to generate, but I have no idea how simple of a fix that may or may not be.

If they end up changing things around but Planet Picker is still having issues let me know and I'll take another look.

I decided to try and decouple the ABS requirement for one of the planets ("Akularis", I removed all references to it at least, and it doesn't crash on startup) and I am still getting the above error. It also doesn't have Solar System++ when crashing. only the mods (outside of space age):

• Akularis (Planet)
• Planet Picker
• PlanetsLib

I have found 4 references to coal specifically; In data.lua (twice in map gen settings) and two in control.lua (get_chances() and draw_chain()) so maybe one of these is to blame? Going to keep looking into this

Current repository fork (if you want to check it out): https://github.com/justin-r-j-logan/planet-akularis

Welp. Its definitely something in the planet mod itself causing the infinite. I can't go to the planet, it crashes immediately.