Hey there,

both the chest opening and chest closing recipe accept quality modules, leading to free legendary iron for the player, presumably not intended.

Secondly, I'm gonna paste a grievance here I've been given about Renai: (tl;dr: Unfiltered event handler super expensive on end game space platforms)

"The problem with Renai (and a couple other mods) is mostly these two event handlers existing at all, with no filter
https://github.com/Kiplacon/RenaiTransportation/blob/master/control.lua#L64
https://github.com/Kiplacon/RenaiTransportation/blob/master/control.lua#L177

Just small promethium asteroids alone is 160k kills/min. That's 44 invocations of on on_entity_damaged + on_entity_died per tick. Each invocation has to go through the event data table construction (LuaHelper::setupEvent), potential LuaEntity construction, and lua garbage collection

For a lot of mods, they listen on on_entity_died with no filter as well (still bad but whatever, that's something for another day), but Renai specifically also has a lot of objects. Lua garbage collection is per-mod, within the context of each mod's set of objects, but Renai also happens to have one of the highest object counts, while its event handler is being called ~100 times per tick, with some those invocation running the very expensive luaC_forcestep (lua GC)"

Thanks a lot!

Huh I never knew the event filters worked like that, thanks for the advice 👌
And yeah allowing quality for the chest closing recipe allows for some pretty intense cheese lol, I should disable that

Heya! So uh closing chests doesn't take quality anymore but opening them still does

https://imgur.com/a/CS9Tlib

As far as the event filters go its genuinely not something I've ever had trouble with but I understand why it'd melt your game with space age mass asteroids

I would think having the Open chest still accept quality modules would be fine no? The player would still have to feed in iron for the closing recipe

As far as I know the open and closing chest recipes only require an open / closed chest and no additional iron? https://github.com/Kiplacon/RenaiTransportation/blob/master/prototypes/OpenContainer.lua

Meaning this is still a closed loop just half as fast? Sorry if I misunderstood
https://imgur.com/a/BYg31HP

Oh you're right, I though I made the recipe need an iron plate to "cap" the chest with 😅
I don't really want to change the recipe in case someone is actually using it in an assembler so I'll change that one to also not accept quality