Warptorio2


Factorio but you build your factory in a restricted space that teleports yourself, the platform, and everything on it to a new and uncharted planet in an unknown corner of space, time and the universe while constantly under attack from enemies. This mod increases the difficulty of factorio by making construction harder and making biters a more significant threat, resulting in a unique experience of factorio'ing in a tight space and under pressure, almost like a tower defence game.

Overhaul
11 months ago
0.17 - 1.1
27.9K
Combat Environment

b Harvester combinators are replaced on recall

6 months ago

When recalling a harvester platform, the combinators are deleted and replaced with new blank combinators. This means that any wires connected to the previous combinators will also be deleted and any values in the combinators will also be gone.
(There is a previous locked thread about this issue, https://mods.factorio.com/mod/warptorio2/discussion/6081bb92449c38110e20446e. But I wanted to provide more detail and also a solution)

It seemed to me this could be fixed by not deleting the combinators, so I've looked into the code to find where this happens.
Firstly, near the end of Harv::Recall, you call self:DestroyComboB() which deletes the harvester-side combinator. I'm assuming this is in case a different platform has picked up the combinator? Are you able to check if the combinator has been recalled correctly and either only delete it if it is not; or preferably just move it back to its correct position?
Secondly, at the end of Harv::Recall you call self:CheckCombo(). This currently clears the space where the combinators should be (which will delete the old combinators, losing their wires and values) and places new combinators there. (How about using isvalid to check each combo before replacing it here?)

I would also like to mention, when a harvester upgrades it destroys both of its combinators. This is less of an issue if it only needs to be fixed then, since the belt connections also move so I'd need to rebuild anyway. However this means you don't have to worry about this when changing the recall code.

4 months ago

Did I not already fix this? :O Pretty sure I fixed this...

4 months ago

bump for this issue, additionally every once in a while the warp logistic chests get reset losing their filters and wire connections

New response