Void Snatch places catalysts in the players inventory. brave new oarc (BNO), does not allow anything in inventory. If you enable a remote interface and use an entity array. You'd initialize each item in on_player_joined_game if nil to game.players[event.player_index].get_main_inventory().
But if set to another entity - you would use that entity. I'd point you at a yellow logistics box within each players base. BNO is a multiplayer game.

You'd need to use something like:
storage.inventory[player.index] table for each player.

This would enable alot of other mods to support Void Snatch.

If this doesn't make any sense - I can update your mod and send it to you. The changes are relatively minor.

For now - I will support Void Snatch by disable non character players.

Hello,

Thank you for your suggestions. Yes, this mod was designed mostly for single player without any "exotic" things like prohibited inventory etc.

Your adjustments would be very welcome and I would appreciate it. Does it work for you to create a pull request on a git hub?

I have used GitHub for over ten years, but all within the constraints of Visual Studio - which has an excellent interface and very intuitive. I've done ONE pull request when I updated Alien Modules to work with Forces (multiple teams). I am unsure how to proceed with a Pull Request, I posted a PR in github to link to a pull request, do I just clone the "https://github.com/bulgakoff08/void-snatch" repository or do you setup a branch ? Sorry - I do this rarely, but am quite experienced at coding factorio mods and am a professional software engineer.

In reviewing your code, I don't think there will be an issue with teams, but I'll need to test that.

I need to do a release update to BNO tomorrow, but should be able to work on this afterwards. I've added support for VS in the new release to BNO but I had to limit it to character only mode. I plan on hosting it on one of my servers tomorrow (Thursday) - search "Maroons" to find my servers. We'll know pretty quickly how Void Snatch works with multiple bases and many players each with their own base.

I should have some feedback by this weekend of making VS work with mods that require the catalysts be delivered to some other storage entity besides a players inventory.

Mostly done. I need to add the remote interface and use it from within BNO.
Also look at function on bottom of control.lua. This should work for players updating their existing version of VS.

When I was working on pull request for atomic artillery I just forked an original repository, made my changes on forked one and then after committing to master I was able to make pull request for original repository in github web ui itself.

As I understand most adjustments would happen in control file so I do not mind if you simply copy it here or just make a file on pastebin / google doc / etc. so I could simply get it by link. It's plaint text after all

Right - all work done in control, info and changelog. I did modified your change log so that it follows the way factorio works on the key words.
Testing more today. You did a nice job with designing your prototypes. I could work with Photoshop, but am not a graphics artist.

Maybe we should chat more directly - contact me https://discord.gg/H8jPyM9y so you can see some of the changes without me posting crap here.

I can't DM you in discord since you left the server, a different option is to mute groups so you are not notified of updates to that group.
Anyway - I was going to add the support to optionally redirect the inventory to another entity for mods like Brave New Oarc.
I didn't want to play tug of war with the code, should I do a fork?

Oh, what a stupid rule of Discord to be honest. I didn't have any intention to break our personnel communication)) I sent you a friend invite so we can talk further