When an entitiy is already legendary, the upgrade is no longer checked for it so if I add the modules after it is already maxed, module can no longer be upgraded. continue generating credits setting does not affect the modules I think

Yes, that is true, it was originally designed that way because checking modules every time would slow down how long it takes to process the queue.

I’m open to revisiting this or adding it as an option though. It would be nice if modules could advance that way.

I’ll look and see if there are any API hooks for when modules are added or removed, which would let me track only ones that have room for upgrading. Otherwise we have to check every entity in case the player changed modules since we last looked at it.

Just want to follow up - I'm testing out a mode that lets modules upgrade independently of the machine they are in. I think it'll be a nice change - it's kind of an either/or option, either modules upgrade when the machine upgrades, or they have their own independent chance and will continue to work even when their parent entity are maxed. Hopefully that's an ok trade off?

Since there are ~4x the entities to check, the overall time it takes to visit every machine in a factory will go up, but there shouldn't be a UPS impact.

that is great! thank you for your help