miniMAXIme: Character scaler and selector

by Pi-C

The player stands like a giant near the vehicles. Now you can adjust the size of your character -- and you can change your appearance at any time if you've other mods that provide extra characters!

Tweaks
11 days ago
0.16 - 2.0
26.4K

g [Not our bug] Mod conflict - Realistic Flashlight

7 months ago

Hey Pi-C,

I use the mod Realistic Flashlight and just tried your mod out in conjunction with it, but noticed that when switching to any character model other than the default, it reverts the changes that mod makes. I'm not sure if there's anything that you can do about it from your end... I know the other mod author hasn't responded to posts for about 2 years.

If it's not fixable from your end, then maybe I can try creating a new version of their flashlight mod with whatever needs to be fixed.

7 months ago
(updated 7 months ago)

Hi,Fury! Realistic Flashlight (RF) is borked. If Gear Girl (GG) is active, RF will create the character halo and the flashlight for data.raw.character.character in data-final-fixes.lua instead of in data.lua. miniMAXIme expects that character mods will create new characters in data.lua and not touch the default character until the data stage. Character mods should then either propagate all changes made to the default character to their own characters (if miniMAXIme or any other known character selector mod is active), or copy their changes (but nothing else, thus preserving changes made by third mods) to data.raw.character.character if no selector mod is active.

GG is borked as well. That was the mod that caused me to add the character selector mode to this mod, so I myself provided the code for creating the new character. Naturally, I didn't have much experience with characters at the time, so I improved my own mods (this one and my reference mod I, Robot) along the way. I even made a helper mod that handles the technicalities of copying attributes from/to characters, so authors of character mods could concentrate on making graphics and sounds for their characters. Unfortunately, the author of GG has disappeared before that, so GG still has my original (now obsolete) code -- and as I never had collaborator status on that mod, there is no way for me to update it.

So, the most simple solution: Disable GG and use another character! If you remove it, RF will act in data.lua, so its changes should be applied to all characters supported by miniMAXIme.

If you really want to get your hands dirty, make a fork of GG using my helper mod (it contains a detailed description and example code). Your fork should conflict with the original mod -- otherwise, if both GG mods were active, RF would still act in data-final-fixes.lua only. Don't forget to provide a link to your fork, so that I can add it to the optional dependencies of miniMAXIme!

7 months ago

Ahh, ok, so the real culprit here is the way RF reacts when GG is loaded. Hmm... yeah, I may do something about this. One or the other or both. :) Can't make guarantees at the moment, though. :P

7 months ago

Ahh, ok, so the real culprit here is the way RF reacts when GG is loaded.

I'd say the real culprit is GG. RF's code running in data-final-fixes when GG is active was a quick hack to fix this bug. While ugly, there was nothing seriously wrong with the fix when it was made (about 3 years ago) because there were only a few character mods available at the time, and I believe GG was the most prominent. That's different today as there are many other character mods available, so third-party mods should not be hardwired to deal with only one particular character mod, but should be general enough to deal with all of these.

You may want to check whether moving RF's data-final-fixes.lua to data-updates.lua would work. But in my opinion, it really would be better to go directly to the root of the problem and fix GG. This might also solve a different problem: The original GG mod still is rather prominent, so authors of other character mods have used GG as a template. This perpetuates the bad practices I've made at a time when I still was experimenting and poking around in the dark.

6 months ago

It's now done. :)
New Gear Girl Character

6 months ago

Great! I've added an optional dependency for your mod to version 1.1.39. :-)

6 months ago

By the way, it seems after I posted the new version up, the original modder broke their silence: https://mods.factorio.com/mod/GirlCharacter/discussion/663483b82974d3a5e5dd3150

New response