Fails to load mod when combined with More Ammo

https://mods.factorio.com/mod/More_Ammo?from=search

Unfortunately it looks like the compat issue is on their side, I'll mark it incompatible until I can look into it more. Thanks for the report!

I fixed the issue on my end, our mods should be compatible now.

Btw, your mod expects the ammo type to have source-effects, but this is not always the case, and it's not mandatory for the prototype.

That's awesome, thanks!

I think I am checking for source_effects correctly but maybe I'm missing something.

  local new_source_effects = {}

      if not delivery.source_effects then goto continue end
      for _, effect in ipairs(extract_source_effects(delivery)) do
        table.insert(new_source_effects, effect)
      end
      ::continue::

Loop over the ammo actions and their action_delivery, initialise an empty array as to not assume any source effects will be found, check for delivery source effects, add any found to the array and then inject them into the new projectile ammo type. Same as I do for the target effects. If none are found it simply uses the empty array.

I'm probably missing checks for other things. Type safety especially. The API lists a lot of stuff as possible that I've never run into while other stuff is not listed as possible but is supported and does work... Right now I'm happy enough tackling individual instances as they come up until I gain a bit more experience with the engine or get much more free time.

Don't know if this is on More Ammo's side but firing a shotgun loaded with Uranium shotgun shells makes it fire like a hitscan vanilla gun.

Video for proof. https://streamable.com/5l39lp

Shotguns shoot projectile in the base game so I don't modify them. Looks like that mod adds hitscan shotgun ammo, might be an accident on their side?

Either way I don't think it makes sense for me to undo what they're doing to turn it back into a projectile, seems a little strange. Thanks for the report though, I appreciate the video!

Shotguns shoot projectile in the base game so I don't modify them. Looks like that mod adds hitscan shotgun ammo, might be an accident on their side?

Either way I don't think it makes sense for me to undo what they're doing to turn it back into a projectile, seems a little strange. Thanks for the report though, I appreciate the video!

Thank you for the clarification and the reply. Will make a thread about it in the respective mod then, since the creator might not see this in time.