Awesome sink

by Quezler

Feed items inside and get a higher quality item every X items without random chance.

Content
4 days ago
2.0
1.80K
Factorio: Space Age Icon Space Age Mod
Mining Manufacturing Cheats

b Item/Machine

11 days ago
(updated 11 days ago)

Hi! I'm the author of "Quality Assurance" and am trying to fix a compatibility issue with your mod. While I can fix the issue on my side, the end result isn't as good as it it was fixed on your end.
This is the relevant code:
AMSMachineItem = table.deepcopy(data.raw["item"][Machine.name])
AMSMachineItem.name = AMSMachine.name
The problem is that there is no item with the same name as the machine (any of CraftingMachine, AssemblingMachine and Furnace) - When I fix the issue, this code will copy the item as above, or copy the item with Machine.MachineItem as the name instead of Machine.name, or create a new item from scratch, (with the assembling machine 2 icon) depending on which is valid. If you want me to be able to keep the icon of the original item, you can add the MachineItem property to your entity. Though, changing the name of the item/entity to match the other would also work, but would be more complicated due to the involvement of migrations.

11 days ago

hmm thanks for reaching out fellow modder, why exactly does your mod need an item to exist? i read over that mod's description, but it just mostly seems to unlock qualities, does your mod try to make a new tier of the awesome sink or something? i currently fail to see the full scope

11 days ago
(updated 11 days ago)

hmm thanks for reaching out fellow modder, why exactly does your mod need an item to exist? i read over that mod's description, but it just mostly seems to unlock qualities, does your mod try to make a new tier of the awesome sink or something? i currently fail to see the full scope

See this:

AMS Machines - Adds new machines which have additional module slots. These are slower than their normal counterparts, but the 2 extra module slots are worth it.

The code I showed you is for making AMS Machines, specifically the item. (There is more code, but what's relevant is that my mod is trying to index nil)

11 days ago

my mod will not work with machines that have a different name, so me adding an item so your mod can make an entity that will not work anyways seems a bit like wasted effort, i suggest just ignoring machines that have no item.

alternatively you could ask other mods to opt_out of the mechanic with like a quality_assurance_extra_tier_opt_out or something, though probably the easiest to maintain from your end is just a table with a hand curated list of names that are blacklisted.

i do apologize for appearing to be uncooperative/unwilling, its not often that other modders reach out for compatibility help and i genuinly wish to come to a positive solution, but atm i do not feel like giving my entity an item of the same name is the most sensible approach to your goal right now.

11 days ago
(updated 11 days ago)

my mod will not work with machines that have a different name, so me adding an item so your mod can make an entity that will not work anyways seems a bit like wasted effort, i suggest just ignoring machines that have no item.

alternatively you could ask other mods to opt_out of the mechanic with like a quality_assurance_extra_tier_opt_out or something, though probably the easiest to maintain from your end is just a table with a hand curated list of names that are blacklisted.

i do apologize for appearing to be uncooperative/unwilling, its not often that other modders reach out for compatibility help and i genuinly wish to come to a positive solution, but atm i do not feel like giving my entity an item of the same name is the most sensible approach to your goal right now.

Ah, I just checked the source and it seems the furnace-entity is for internal reasons - I guess I'll have to add a blacklist + opt-out. (So either me or the developer of the incompatible mod can fix the issue)

11 days ago

yea my furnace entity is just so the modules have to place a sit and can be blueprinted/upgraded

10 days ago

I'm adding an opt out feature for AMS machines in version 1.2.0 of QA. I've created a pull request for adding this to the furnace-entity.

10 days ago

pull request merged and 1.1.5 released

10 days ago

;)

10 days ago
(updated 10 days ago)

it seems there is no comma after the newly added line "no_ams = true" in data.lua which means the game cant load with the mod active

10 days ago

thanks, fixed in 1.1.6

10 days ago

Sorry, forgot.

10 days ago

eh im just glad someone reported it in time, no actual harm done

New response