Rampant Arsenal

by Veden

Adds a variety of weapons to wage war. Adds Additional Turrets, Ammo Types, Landmines, Equipment, Capsules, Walls, Vehicles, Infinite Technologies

Content
1 year, 10 months ago
0.16 - 1.1
136K
Combat

b Failed to load mod on Update 0.18.16

4 years ago
(updated 4 years ago)

When starting Factorio with only this mod enabled, I get the following error message:

Failed to load mods: The given sprite rectangle (left_top=0x1764, right_bottom=104x1848) is outside the actual sprite size (left_top=0x0, right_bottom=104x1826).: _ _ base _ _ /graphics/entity/tank/tank-base-mask-1.png

Mods to be disabled:
- RampantArsenal (0.18.1)

4 years ago

+1

4 years ago
(updated 4 years ago)

Just an update, the error only occurs when Sprite Resolution is set to Normal. (Option found in the Graphics Settings.)

Setting Sprite Resolution to High will resolve the issue.

But, this will still be a problem for players using older graphics cards that do not have enough VRAM to support the High Sprite Resolution setting. (3GB VRAM recommended.)

4 years ago
(updated 4 years ago)

Looks like maybe they shrunk the tank sprite by 6px height? https://github.com/wube/factorio-data/commit/43c30df953aa2b4166288cc400dcdda38f71a38b#diff-155ed503960b97ae0fa40493deb429aaR15

I don't know if this helps, I've never modded factorio or coded lua but thought I'd take a look out of curiosity.

Maybe need to change this line to 100 height? https://github.com/veden/RampantArsenal/blob/04ede7ac5a9a3196d422e1960fcdfe2893b399e0/prototypes/utils/VehicleUtils.lua#L148

Not sure how to test it so I won't submit a pull request, but I suppose if you don't get to it before I figure that out, I'll submit one on github there.

EDIT: Oh wait, this seems very relevant! https://github.com/wube/factorio-data/blob/43c30df953aa2b4166288cc400dcdda38f71a38b/base/prototypes/entity/entities.lua#L1505

Ok, think I got it. Pull request here if you are open to that kind of thing Veden.
https://github.com/veden/RampantArsenal/pull/5

4 years ago

Thanks YenRaven.

Change this line
https://github.com/veden/RampantArsenal/blob/04ede7ac5a9a3196d422e1960fcdfe2893b399e0/prototypes/utils/VehicleUtils.lua#L219
for this
height = 83,

and this line
https://github.com/veden/RampantArsenal/blob/04ede7ac5a9a3196d422e1960fcdfe2893b399e0/prototypes/utils/VehicleUtils.lua#L223
for this
shift = util.by_pixel(0, -21.5),

(Sorry for the English language, written by Google Translator)

4 years ago

this has been merged

New response