Unknown key: "entity-name.OSM-offshore-pump-collision-layer" is in the way

Reproduce is placing an electric offshore pump then deleting it and trying to place something in it's place

Screenshot:

https://up.cloudcat.ca/s/s7o7mnpn.png

Messed up the tag, sorry

Modlist: https://up.cloudcat.ca/7zaww5jy.json

That's interesting, having a look now

i managed to fix it, looking at another bug (see other threads) and i'll roll out the update.

Thanks for reporting, i completely missed that collision layer thing

FIXED!

I still get this bug on latest version 1.1.66, mostly did the same, remove pumps put landfill, a invisible entity exist and prevent anything to be placed. Pumps was removed by robot.

whoops, might have missed the robot thing, does it happen when you remove it by hand?

I can't reproduce with hand or robot, but my game is new and only run the 1.1.66 version of the mod, I mostly put burner then replace by electric tier 1,2,3,4 the pump probably by robot (I was using https://mods.factorio.com/mod/Companion_Drones early game maybe that them ?). I'm doing a poor bug report ^^'.

Removing the mod remove 339 OSM-offshore-pump-collision-layer for 26 pumps.

But I confirm "Unknown key: "entity-name.OSM-offshore-pump-collision-layer" is in the way" for my 4 first pump of my game.

This is a bit confused, i can't reproduce the bug myself hence i'm not sure what your problem exactly is and why it happens, you mean that if a companion from the mentioned mod mines an offshore pump its collision layer still exists?

Sorry, I don't know I need more testing, I will come back when and if I have a better bug report.

you mean that if a companion from the mentioned mod mines an offshore pump its collision layer still exists?

Maybe, since there are kind of hacky mod from Klonan the hack master ^^ Thus that may come from my 999 other mod

Yh, that's why i tend to avoid his mods xD (though they're all top notch codewise)

I think i actually have good news, i've just realised that the clean-up code for collision leftovers did not work as intended, will be fixed in v1.1.67

Got this

2.618 Loading mod P-U-M-P-S 1.1.67 (data.lua)
2.669 Error ModManager.cpp:1558: Failed to load mod "P-U-M-P-S": P-U-M-P-S/core.lua:55: attempt to call field 'make_collision_layer' (a nil value)
stack traceback:
P-U-M-P-S/core.lua:55: in main chunk
[C]: in function 'require'
P-U-M-P-S/data.lua:12: in main chunk
2.671 Loading mod core 0.0.0 (data.lua)
2.727 Checksum for core: 1224479708
2.797 Error ModManager.cpp:1558: Error in assignID: recipe-category with name 'crafting' does not exist.

Also got the error above.

Whoops, i think i uploaded the wrong version xD, i'm out a couple if days, i'll check it then.

It does happen on startup isn't it?

yeap,startup

Actually i think i know what i've done, a while ago i've changed a few lines in my lib and i might have changed that reference and forgot to update it, this version should be good, i'll let you know in a couple of days once i get back to my PC

No worries take your time

library updated, hence... FIXED!

thank you Mr. Wizard

I have a similar issue with the entity thing, not the error. It removes them if they are mined and the game is reloaded with power requirements off, but mining another one leads to the same issue, just reloading does not seem to remove them. I've not been able to reproduce the problem reliably. I'm going to try some other things, if I can reproduce it reliably I'll explain it here.

It seems to happen when there are pumps placed and mod (or startup settings) are changed. However this also spawns bees from the forestry mod, so it's very likely caused by another mod I'm using. The way I've found to fix this is by removing either every single pump (leaving the entities behind) and reloading with a mod (setting) change or removing and adding this mod back, causing all pumps to be removed of course. If I can find the mod causing the issue I'll put it here

I did some more testing. I was only using the creative mod, this one, the osm lib mod, and the osm lib post-process mod. I've used the creative mod to unlock all tech and placed an offshore pump and steam power, after disabling the creative mod and loading the save back in the entity was there if I mined the offshore pump blocking me from placing anything but the offshore pump.

I'll have a look

this just happened to me, i was playing on freeplay i was about to change one of my factories and i can't place anything in the same place as the OSM-Offshore-pump-collision-layers after i delete the offshore pumps or weirdly enough ground water pumps form Angels, also even if i wanted i can't place better ones or same tiers in the same place at previous

I also faced this issue today with latest version of this mod (and it's dependencies). I'm using a ton of other mods, but AFAIK none of those touch the pumps. The closest other mod might be flow-control. Anyway, I did the disable + re-enable pumps mod trick and replaced the pumps manually. Luckily I only have pumps in three places, so it was not so hard to do. If you want more information for degugging this, let me know!

EDIT: My savegame was started before the last update. I'm not sure about the timing of the problematic pumps with mod update. Is it possible that the "left-overs" were present in the map before the update and they are still there?

It appears that multiple collision layers are overlapping in the same location, they all need to be deleted.