P.U.M.P.

by Xcone

P.U.M.P. (Prevent Unwanted Manual Pump-placement) adds a selection-tool with which you can select oil wells, and then plans the layout of pumpjacks and pipes for you.

Utilities
a month ago
0.18 - 2.0
74.8K
Mining Fluids Blueprints

b Conflict with another modem

4 days ago

Hello.
I encountered a conflict with another modem:

Error while running event what-items-do-i-have::on_runtime_mod_setting_changed (ID 69)
Invalid ItemID: expected LuaItemPrototype, LuaItemStack, LuaItem or string.
stack traceback:
[C]: in function 'get_item_count'
what-items-do-i-have/control.lua:257: in function 'search'
what-items-do-i-have/control.lua:322: in function <what-items-do-i-have/control.lua:320>
stack traceback:
[C]: in function 'newindex'
__pump
/toolshop.lua:339: in function 'close_tool_picker_ui'
pump/control.lua:25: in function <pump/control.lua:21>

Is it the fault of this mod or that one?
Best regards.

4 days ago

I doubt it's my mod. I'm not in a position to debug it at this time. But its pointing to a line of code in my mod where I assign one of my own settings of my own mod. So I have no clue how that line of code ends up in a stack trace all the way to the other mod.

Only thing I can imagine is if their mod uses the same identifier of a UI item or setting that I have in use. There's naming conventions and recommendations to avoid those. Which I believe I am following at this point.

If I were in a position to try it. I could confirm it. But until then I'm in the impression the problem resides in the other mod. If they say the same thing, I'll happily debug this at a later date and see where it leads.

4 days ago

Since they're opensource, it allowed me a peek at their code. It seems me saving a setting in my mod causes the game to raise an event that a setting (any setting) is changed. Thats not me, but the game doing that.

In the other mod they neglect to check which setting is changed. (Line 320). Maybe that intentional. But it seems to have very little safeguards. So my guess is they need to add some sanity checks there about the setting-change they're acting on.

3 days ago

Thanks

New response