Hello! Just discovering this mod, and I think it's exactly what I would like, however, it seems to not work with modded fluid icons, specifically the ones introduced in this mod: https://mods.factorio.com/mod/BarrelFluidIcons

Is there anything in particular you can do to make this mod support those barrel types?

I will take a look. In which places did you notice the problem?

Basically all non-vanilla fluids, from what I can tell. I have several mods installed that add new fluids (like Maraxsis, Cerys, Corrundum, etc.) and all of their associated barrels are showing up when I'm in the remote view cursor menu (the one you see when you press "E").

I actually was in the process of putting together a PR, since it seems like the techs are hardcoded here: https://github.com/Tooster-modding/Factorio-barrel-stages/blob/master/src/data-final-fixes.lua

Would you be open to me opening a PR there? Or is there a more clever solution? I'm new to modding Factorio, so I'm naturally open to you taking point on it if there's a more-elegant solution.

Ended up doing it anyway :) https://github.com/Tooster-modding/Factorio-barrel-stages/pull/3

Hi there! Stumbled upon this and think it's an interesing mod, will try; wrt to the PR you created @macintacos, about a generic way (https://github.com/Tooster-modding/Factorio-barrel-stages/pull/3#issue-3327786920), maybe one could steal the idea they have: https://github.com/TheTaurunti/factorio-barrelfluidicons/blob/7e61d9010c658558ab5a2b88b0af254fa7405606/data-updates.lua#L66

I think they loop over all fluids, try to deduce the corresponding barrels and then act on that. I think something like that should be possible for "Barrel stages", too? I don't have the time to mess around with it, just thought I'd post the thought.

Thanks for the PR! I am also pretty new to factorio modding and always accept any contributions with open arms :) I will try to look into it now - I am a bit confused by the description of the BarrelFluidIcons. I think the hardcoded way is fine for this case considering barrel recipes need to be connected to technologies with non deterministic names. I'll be writing further comments on PR because they are more relevant there (and I also get notifications ;) You are incredibely lucky I saw your post 2h after you posted it here, because I entered factorio mod portlal randomly after a longer break :D

Wonderful. I appreciate that stef77 nudged me in the generic direction - the PR I opened now should support all modded fluids, assuming that they have a corresponding barrel recipe.

Something to note - I'm assuming that a lot of folks will probably want to use this mod with Barrel Fluid Icons (it just attempts to add barreling recipes for all fluids, modded or vanilla), but there is some issue that I've uncovered that I think has nothing to do with this mod (or the work that I did in that PR), but it's something to be aware of: https://mods.factorio.com/mod/BarrelFluidIcons/discussion/68a241749e5c054031411bbf

I'm hoping that it's easy to resolve, but if it's on the original mod to fix, then might be worth adding a disclaimer to the mod description or something to describe what to do.