SSPP Logistics Train Mod

by jagoly

A logistics train mod that aims to be as pleasant to use as possible, even when knee-deep in byproducts. SSPP stands for Source-Sink-Push-Pull.

Content
a day ago
2.0
594
Logistics Trains

g Signal mismatch after copy-paste and edit

a month ago
(updated a month ago)

I copy-pasted a layout and it worked fine, except for the signals. They don't seem to notice edits.

From this image: https://drive.google.com/file/d/1HJsT3wrdnnFn3_ZFudU6Pgw9-9hYiyTO/view?usp=sharing

Although I've subsequently changed the item type being provided from Stone Furnace to Rail, the SSSP module still thinks it a Stone Furnace, and that gets passed to the filtering on the inserters.

If you don't get an event for this, can you make SSSP poll occasionally for changes to the item being provided / received and update the modules to match?

Thanks :)

a month ago

Ah, yeah I see. The output signals aren't getting cleared if you copy paste a station that is currently loading or unloading a train. I should note that as soon as a train actually arrives, the signals would get set correctly. I'll still fix it though because it is confusing. Thanks for catching this!

a month ago

Fixed in the new version, thanks again!

a month ago
(updated a month ago)

Thanks for the update. Unfortunately, I think it still has a problem. While it was auto-completing some of my new blueprints (copy-pasted, as before), I encountered this:

The mod SSPP Logistics Train Mod (0.4.0) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event SourceSinkPushPull::on_robot_built_entity (ID 17)
SourceSinkPushPull/scripts/lib.lua:94: value not found
stack traceback:
[C]: in function 'error'
SourceSinkPushPull/scripts/lib.lua:94: in function 'list_remove'
SourceSinkPushPull/scripts/main/station.lua:295: in function 'on_comb_broken'
SourceSinkPushPull/scripts/main/station.lua:329: in function 'destory_invalid_ghosts'
SourceSinkPushPull/scripts/main.lua:33: in function <SourceSinkPushPull/scripts/main.lua:14>

If you load this save:

https://drive.google.com/file/d/1YVGQBo-CNTCoP-Q7H3-CNk6SWWmIE2oq/view?usp=sharing

and wait about ten seconds, it will crash when the robot tries to build the SSPP station above and slightly to the left of the character.

[edit: I've just noticed that my Research button appears to have disappeared, so there may be a problem with my installation of Factorio.]

a month ago

Update to the above:

If I disable this mod:

https://mods.factorio.com/mod/manual-trains-at-temp-stops

the crash does not happen. Should I tell that author, or is this a problem inside SSPP?

a month ago
(updated a month ago)

This crash isn't happening for me at all, with or without that other mod. Does it happen every time for you or only sometimes?

Edit: Nevermind, managed to reproduce it. Seems to be that the issue was getting hidden by a mod change (sspp does some stuff when any mod or setting changes to keep track of things). Removing (or adding) any mod would hide the issue, not just the one you mentioned. Investigating now...

a month ago
(updated a month ago)

Ok, I think I've now fixed the cause of the issue. Basically my workaround for https://mods.factorio.com/mod/SourceSinkPushPull/discussion/67d7df954d033471876f6520 was incomplete, it was still possible to cause issues if you copied a non-ghost and pasted it on a ghost. But now it should finally be fixed (I hope).

Also I just wanna say that your bug reporting has been extremely helpful, and I thank you for your persistence! Hopefully things will go more smoothly for you from now on.

a month ago

Thanks for the fix. You're welcome re: the bug reporting. I've been developing code for 35 years now, so I know what it's like to get user reports that "it doesn't work" and nothing else! :)

New response