Hi, I noticed that the pumpjack selection UI in Oil Outpost Planner shows hidden entity variants from other mods, specifically the productivity variants created by my Better Pumpjacks mod (e.g. pumpjack-mk2-prod-1, pumpjack-mk3-prod-2, etc.).
These are internal entities marked with hidden = true that players are never meant to interact with directly, but they show up as selectable options in the UI panel which cause a crash if interacted with.
The root cause is in gui.lua in the update_pumpjack_selection function — it checks the blacklist but doesn't filter out hidden entities. The update_entity_selection function (used for pipes, poles, beacons, etc.) already handles this correctly with:
if entity_proto.hidden then goto skip_entity_proto end
The fix is to add the equivalent check in update_pumpjack_selection, right after the blacklist check on line 305:
if miner_proto.hidden then goto skip_miner end
That one line would filter out hidden mining-drill variants from any mod, not just Better Pumpjacks.
https://gyazo.com/284c0b5a89bbcf53a5b4e4e47cfc02d0 is what it should look like.
Cheers