While exploring the bug where capsules weren't creating recipes I stumbled on the bug that ineligible resources (in vanilla/space age that's all the fluid resources such as crude oil, sulfuric acid etc.) still have an attack proxy unit, smoke explosion and pot animation made for it that end up unused.
That's because the checking for eligibility happens in the make_recipes
function, while in the same for-loop the other three prototypes are created without that check.
The easiest fix would be to let make_recipes
return a boolean at the end of the function to signal it has added a recipe and use that to skip the rest of the add_
functions if it's false.
Hope you don't mind me reporting all these edge-case bugs 😇