Improved Combinator


The mod provides a custom entity which allows the user to create any number of decider & arithmetic combinators in a single entity. Improved Combinator also provides timer utilities that allow for timers to be setup which can call specific combinators at a specified time.

Content
3 years ago
0.18 - 1.1
14.2K
Circuit network

b Crash on copy-paste entity

8 months ago

Have encountered a crash where a certain improved combinator cannot be disconnected from one of its existing inputs, deleted, or copy/pasted, without crashing the game. Disconnecting the input gives an in-game error and closes the world, while deleting the entity or trying to paste it crashes the game itself. Not sure if this mod is still being updated, but wanted to warn others that it's unstable under certain circumstances.

World-crash error log:
Error while running event ImprovedCombinator::on_tick (ID 0)
Value (-inf) outside of range. The data type allows values from -2147483648 to 2147483647 in property tree at ROOT[5].count
stack traceback:
[C]: in function 'newindex'
__ImprovedCombinator
/scripts/updates.lua:419: in function 'write_output_signals'
ImprovedCombinator/scripts/updates.lua:487: in function <ImprovedCombinator/scripts/updates.lua:472>

Game crash error log:
Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\users\build\appdata\local\temp\factorio-build-axh5wp\src\floatcast.hpp (101): float_cast<int>
c:\users\build\appdata\local\temp\factorio-build-axh5wp\src\util\propertytree.hpp (358): PropertyTree::get<int>
c:\users\build\appdata\local\temp\factorio-build-axh5wp\src\circuitnetwork\behaviors\constantcombinatorcontrolbehavior.cpp (37): ConstantCombinatorControlBehavior::loadFilters
c:\users\build\appdata\local\temp\factorio-build-axh5wp\src\script\luacontrolbehavior\luaconstantcombinatorcontrolbehavior.cpp (67): LuaConstantCombinatorControlBehavior::luaWriteParameters
c:\users\build\appdata\local\temp\factorio-build-axh5wp\src\script\luacontrolbehavior\luaconstantcombinatorcontrolbehavior.cpp (42): LuaConstantCombinatorControlBehavior::luaNewIndex
c:\users\build\appdata\local\temp\factorio-build-axh5wp\src\script\luabinder.hpp (348): LuaBinder<LuaStruct<GameViewSettings> >::callWrapperOnObject
c:\users\build\appdata\local\temp\factorio-build-axh5wp\libraries\lua\ldo.c (352): luaD_precall
c:\users\build\appdata\local\temp\factorio-build-axh5wp\libraries\lua\ldo.c (425): luaD_call
c:\users\build\appdata\local\temp\factorio-build-axh5wp\libraries\lua\lvm.c (104): callTM
c:\users\build\appdata\local\temp\factorio-build-axh5wp\libraries\lua\lvm.c (168): luaV_settable
c:\users\build\appdata\local\temp\factorio-build-axh5wp\libraries\lua\lvm.c (604): luaV_execute
c:\users\build\appdata\local\temp\factorio-build-axh5wp\libraries\lua\lapi.c (1067): f_call
c:\users\build\appdata\local\temp\factorio-build-axh5wp\libraries\lua\ldo.c (137): luaD_rawrunprotected
c:\users\build\appdata\local\temp\factorio-build-axh5wp\libraries\lua\ldo.c (625): luaD_pcall
c:\users\build\appdata\local\temp\factorio-build-axh5wp\libraries\lua\lapi.c (1093): lua_pcallk
c:\users\build\appdata\local\temp\factorio-build-axh5wp\src\util\luahelper.cpp (4474): LuaHelper::pCallWithStackTrace
c:\users\build\appdata\local\temp\factorio-build-axh5wp\src\script\luagamescript.cpp (1123): LuaGameScript::runEventHandler
c:\users\build\appdata\local\temp\factorio-build-axh5wp\src\script\luaeventdispatcher.cpp (695): LuaEventDispatcher::run
c:\users\build\appdata\local\temp\factorio-build-axh5wp\src\script\luaeventdispatcher.cpp (115): LuaEventDispatcher::dispatch
c:\users\build\appdata\local\temp\factorio-build-axh5wp\src\scenario\scenario.cpp (1312): Scenario::update
c:\users\build\appdata\local\temp\factorio-build-axh5wp\src\scenario\scenario.cpp (1207): Scenario::updateStep
c:\users\build\appdata\local\temp\factorio-build-axh5wp\src\mainloop.cpp (1372): MainLoop::gameUpdateStep
c:\users\build\appdata\local\temp\factorio-build-axh5wp\src\mainloop.cpp (1225): MainLoop::gameUpdateLoop
c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\functional (15732480): std::_Func_impl_no_alloc<<lambda_8d1f6919bc377b8fec237b052c484c9a>,void>::_Do_call
c:\users\build\appdata\local\temp\factorio-build-axh5wp\src\util\workerthread.cpp (73): WorkerThread::loop
c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\thr\xthread (230): std::_LaunchPad<std::unique_ptr<std::tuple<void (__cdecl MapGenerationHelper::)(void),MapGenerationHelper >,std::default_delete<std::tuple<void (__cdecl MapGenerationHelper::)(void),MapGenerationHelper > > > >::_Go
c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\thr\xthread (209): std::_Pad::_Call_func
minkernel\crts\ucrt\src\appcrt\startup\thread.cpp (97): thread_start<unsigned int (__cdecl)(void ),1>
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFB4A9F7344)
00007FFB4A9F7344 (KERNEL32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFB4C3026B1)
00007FFB4C3026B1 (ntdll): (filename not available): RtlUserThreadStart
Stack trace logging done
37.523 Error FloatCast.hpp:101: !std::isnan(input) was not true
37.523 Error CrashHandler.cpp:641: Received 22
Logger::writeStacktrace skipped.
37.523 Error CrashHandler.cpp:195: Map tick at moment of crash: 12960317
37.569 Info CrashHandler.cpp:315: Executable CRC: 1619815914

New response