Hexy's AngelBob Tweaks


Makes many small tweaks to AngelBob's to make the experience more coherent, as well as reorganize items completely.

Tweaks
5 years ago
0.17
14

b Crash when Angel's Smelting Complete is added

5 years ago

Mods to disable:Failed to load mods: Hexy_AngelBob_Tweaks/data-final-fixes.lua:2: Hexy_AngelBob_Tweaks/prototypes/deuterium.lua:9: attempt to index field 'bob-heavy-water' (a nil value)
stack traceback:
Hexy_AngelBob_Tweaks/prototypes/deuterium.lua:9: in main chunk
[C]: in function 'require'
Hexy_AngelBob_Tweaks/data-final-fixes.lua:2: in main chunk
stack traceback:
[C]: in function 'require'
Hexy_AngelBob_Tweaks/data-final-fixes.lua:2: in main chunk

5 years ago

Can I get a full mod list?

5 years ago

Yeah... At the begining I thought it was some conflict with both mods but now that I think... I have a lot of stuff changing Bobs/Angels... Something might be changing the heavy water too... Funny that it isnt an issue without the new Angels smelting complete!!

Here is the link to my mod-list.json: https://www.dropbox.com/s/dmkw7oo0077o1do/mod-list.json?dl=0

5 years ago

What is this mod "CustomChanges"? It doesn't seem to be on the mod portal.

5 years ago

Ohh, its my personal mod where I do personal tweaks and stuff like that.
On this pack he his currently empty and doing nothing.

5 years ago

Found the issue.

You should avoid touching fluids on data-final-fixes because its the only stage where mods like omnipermutation can manipulate the fluids.

Its just a coincidence that without the other mod it works. When I add Better smelting, Factorio chooses a new order and omnipermute loads before this one and heavy water recipe does not exist anymore.

We need more then ever an option to indicate that our mod needs to load before other mods. We have dependency but something like I run before this 'mod' would be very useful

5 years ago

Thanks for the debugging help, I didn't really know where to start with this one. I'll see if I can fix this for the next version.

5 years ago

Can you verify that this is still happening on the latest version of this mod (0.17.5)? I moved the deuterium changes to the data phase in that version so I just want to confirm that this is still happening with Omnipermute because I can't replicate it with just omnipermute and my mod added.

5 years ago

Well.... now it complains with angels-ore8-sludge in angels-refining-tweaks...
If you want to go that route, you should temporarily add omnipermute as a dependency on your mod to force it to load after omnipermute. That will allow you to find all conflicts. I would also move the fluid handling to data-updates instead of data, just to guarantee is done in the latest possible phase before omnipermute to prevent issues with bobs/Angels doing something during the data-updates.

Another option is you adding a permanent optional dependency to omnipermute, to guarantee that you always run after it and have your code doing the changes to vanilla bob/angels if you dont detect omnipermute recipes. If you detect omnipermute, you would instead change the omnipermute recipes. The thing is, just for heavy water, they have 48 permutations.... its a pain!

3th option is talking with omnipermute dev. Maybe he can add your mod as a dependency, to guarantee yours always runs last or maybe he has some API in his mod to help solve these issues...

5 years ago
(updated 5 years ago)

I have thought about this for a bit, and am deciding to just mark Omnipermute as anti-compatible with this mod. Fluid Permutations does the same thing but better, doesn't crash the game when other mods try to modify existing recipes after omnipermute has touched them, and doesn't screw up item icons and the order changes I make. This other mod does have a bit of a bug where it doesn't work with MomoTweak at the moment, but it is about to be fixed.

EDIT: Upon further examination, I discovered that omnilib is incompatible with Fluid Permutations, making this a bit infeasible. I am going to look into this a bit more, and see if I can make that not a thing.

5 years ago
(updated 5 years ago)

Yeah... Omnilib author is kinda... doesnt matter...

He marked OmniLib incompatible with Fluid Permutations and GDIW because of his Omnipermute mod... Makes no sense... If you want/need omnilib for some funky mechanics that only his mod provides but you want to use other fluid handling mod, you cant because he doesnt isolate is API...

PS: If I am the only one with this issue... and no one else complains, dont bother with it. I custom changeded omnipermute to have your mod as a dependency to guarantee that omnipermute loads last. So, I know how to bypass and I can live with this annoyance. Dont lose your time fixing this incompatibility if its only because of me.

5 years ago

Problem is all of Omnimatter depends on Omnilib, so you can't use Fluid Permutations and do Omnimatter at the same time, despite the fact that they are perfectly compatible together (I just tested removing the anti-compatibility, everything works just fine), and I don't want to leave those people out in the dust. I will still try to see if I can get this anti-compatibility removed.

5 years ago

angels-ore8-sludge issue fixed for 0.17.7.

This thread has been locked.