Signal Display

by AckEmma

Allows Display Panels and Programmable Speakers to show the count associated with a signal from the circuit network.

Utilities
10 days ago
2.0
840
Circuit network

i [Implemented] Support for item Quality

a month ago
(updated a month ago)

Currently the mod is limited in to what it can support to fill numbers in. Quality doesn't work at all and only items and virtual signals can be used, so fluids and more get missed.

I've had a look and have a changeset here that does what I want. I've not tested it exclusively and have no idea what I'm doing in lua or Factorio modding so treat this as more of a guide.

https://github.com/Caleb-Wishart/signal-display/compare/master...mGuv:signal-display:add-signal-and-quality-support

a month ago
(updated a month ago)

--snip--

a month ago

Whoops hit reply instead of edit.

a month ago

Thanks for the PR and report.

Can you explain more the fluids not working? Is that only in the rich text?

a month ago
(updated a month ago)

Basically it was previously only looking for "item" or "virtual-signal" for strings to replace the value with when in rich text mode, but those are only two of the prototypes.

E.g. a fluid's rich text is [fluid=water] as opposed to [item=foo], ditto with many other signals, Entities, planets, etc..

a month ago
(updated a month ago)

I keep replying instead of editing. I can't get used to this UI apparently.

a month ago
(updated a month ago)

Basically it was previously only looking for "item" or "virtual-signal" for strings to replace the value with when in rich text mode, but those are only two of the prototypes.

E.g. a fluid's rich text is [fluid=water] as opposed to [item=foo], ditto with many other signals, Entities, planets, etc..

Not quite, it was only trying to handle special cases for those rich text (item can be nil in SignalIDType and virtual-signal isn't named consistently), I did however not handle the "planet" case which I do now in 1.3.0

It also now support quality.
You had some good ideas in your PR but could be handled with a single pattern match which is better for performance

a month ago

I tried to do it with pattern matching but I could not figure out Lua regex for the life of me. I ended up splitting it out as verbosely as I did just so I could understand Lua.

Happy you were able to implement it better, glad I could help.

a month ago
(updated a month ago)

Yea, Lua patterns ~= Regex
Lua can be… interesting

New response