Hi again, Kryzeth. While working on the Industrial Revolution 3 Patchset, I've been trying to write support for various popular 2.0 mods (adding custom recipes, tweaking research costs etc.), because what's the point of updating a mod to the current version if it doesn't work with other current mods, right?

In the case of More Long Inserters, I noticed that you had historical support for IR3, and figured that you might prefer to write support from your side.

The mod name to check for is still "IndustrialRevolution3".

Current Status

All filter inserters are deleted from the mod, intentionally part of the Patchset.

Steam inserters and their long-handed versions are completely ignored by the mod. Other inserters have their long versions generated correctly (with vanilla-style icons) and are moved to the "shinyinserters1" subgroup.

Long-handed Burner inserter is incorrectly added to the "Inserters 1" technology.

(Don't worry about the incorrect scrapping recipe translations, I'll handle those.)

Hmm, I actually silently removed a lot of the obsolete support for IR3, since it wasn't going to be officially updated to 2.0, and I can't say I'm all that interested in re-adding any of the specific compatibility for an unofficial update, especially one that requires that much effort to get working (meaning very few users are ever going to see the benefit)

It would be easier to make things work from my end, while the long variants are being generated, but considering the effort it would take to even begin to test if things work... if only a pre-patched version of the mod could be distributed privately for testing...

Sorry, I can't get the link to work. Whenever I access it, I'm re-directed back to my personal page. I'm brand new to Discord and I don't know how it's supposed to work, but I imagine it's probably a security measure against new accounts.

It might be because of my privacy settings, I only tested it with a dummy account that had already been friends with my main account before lol

I sent the request though

The implementation in 5.1.20 seems excellent, exactly what I expected.

EDIT 2: Overlay icons are always added and do not respect IR3's "ir-inserter-overlays" setting, it should occur only when value = "on".

EDIT: A really minor thing: Steam inserters are ordered before Burners when it should be the opposite. I'll happily ignore that.

Long Burner inserters are still unlocked by "Inserters 1", and based on our conversation, I assume this is intentional. When "Costless upgrades" is false, the Long Burner also requires iron components in the recipe, based off the Electric Long inserter.

You have an option to create a Bulk Burner and Stack Burner, which are each unlocked at the appropriate points in progression, so I assume the Long Burner is following that logic.

It would be my preference to have the Long Burner unlocked earlier and use copper-tier ingredients. If you're unwilling to change your generic Long Burner handler, I could write code for this in a "final-fixes-pre" stage before the Scrapping recipes are made. (EDIT: I've now written this code.)

But then we'll have a situation where our mods are grappling with each other, so I'll wait and see what your thoughts are.

EDIT 2: I gave Stack inserters their own unique overlay icon, here's the code I used:

local setting = settings.startup["ir-inserter-overlays"]
if setting and setting.value == "on" then
    table.insert(data.raw.item["stack-inserter"].icons, {
        icon = "__base__/graphics/icons/signal/signal-stack-size.png",
        icon_size = 64,
        icon_mipmaps = 4,
        scale = 0.25,
        shift = {-8, 8},
    })
end

EDIT 3: Really splitting hairs here. The inserter entity has its own icon (which you can see in the Map Editor GUI) and they need to be reassigned as well (currently they look like vanilla-style hybrid inserters). I'm not really sure how icon "inheritance" works, when you need to assign item/recipe icons and when you don't...

Short summary of change in relative order from your comment:

1. Fixed only applying overlay settings when enabled (weird that this is an "on"/"off" string instead of a simple bool, wonder why they coded it that way

2. I noticed this was actually inconsistent in my sorting functionality; when only one row, steam was before burner, but with 2 or more rows, burner was first. I'll put burner first in all cases, makes sense to me

3. Noting: Long burner tech fix applied on your side, no change needed, thanks! Luckily, all my logic runs in or before data-updates, so you can make any necessary changes during final-fixes

4. Manual fix applied to the long burner inserter recipe from my side during inserter generation

5. Added compatibility for the stack icon overlay, though it's likely going to be overlapped by the long icon overlay, similar to how it overlaps the burner icon overlay

6. Fixed the inserter entity icons so they appear properly in map editor (and wherever else that icon might be used). On a related note though, the stack inserter appears vanilla on my end (using space age, not the other mod or any other methods to enable it)

Aaaand I believe that's everything dealt with so far, implemented all changes in v.5.0.21

Fixed only applying overlay settings when enabled (weird that this is an "on"/"off" string instead of a simple bool, wonder why they coded it that way

I'm going to guess this future-proofing in case Deadlock wanted to add a "filters-only", "long-only" etc.

Manual fix applied to the long burner inserter recipe from my side during inserter generation

Oh, I covered this already. Not sure who's winning, but it doesn't seem to matter.

Added compatibility for the stack icon overlay, though it's likely going to be overlapped by the long icon overlay, similar to how it overlaps the burner icon overlay

Yes, this is what I expect.

On a related note though, the stack inserter appears vanilla on my end (using space age, not the other mod or any other methods to enable it)

The icon? It seems correct to me. You might be looking at the "remnant" icons under the Environment tab; I don't care about those.

(I'm assuming you've updated your build of the Patchset.)

I think that all seems good, thanks for fixing those!

(By the way, I'm also doing manual handling of Extra Long Handed Inserter when it's loaded with MLI, in case you're wondering what was going on.)

(I'm assuming you've updated your build of the Patchset.)

Bold of you to assume lol

Makes sense if you've updated it by now though, I took a bit of a break last week and a half-ish from modding to just play some stuff