Hello, love the mod, I've wanted to be able to see stack sizes before building for so long.

One issue I have noticed is that it seems to be removing some of the standard descriptions, now in vanilla that isn't a huge issue but I'm doing my first play SE through and having them missing is making it even tougher lol.

Is there anything I can send to help diagnose this issue>?

Many thanks

Will.

this may be an issue from a different mod

I have SE installed and I can see descriptions normally
https://i.imgur.com/AVJwxNU.png

Cheers for the response, like I mentioned its not all descriptionsthat are having the issue and that is one of them that is working.

https://imgur.com/a/ndBYkz3

Sample of one that isn't

https://imgur.com/a/lHjtkMI

From what I can see, they seem to display fine if they have that yellow warning about placement.

But by all means ill try disabling some mods and see if it works.

Does the inserter usually have a description? I'm pretty sure it doesn't have one, even in vanilla.

As far as I understand it: This mod overwrites descriptions of recipes/items where the description is just in locale files and not set by the localised_description-field. Typically, localised_description is only used for generated descriptions (from the Wiki: "Overwrites the description set in the locale file."), so many mods only use locale files.

The problem can be reproduced with different mods, e.g. "AAI Programmable Vehicles".

This mod never overwrites entity descriptions, only item descriptions.

If you want to see the default description, just place the entity down. :)

Uhm, if an item shows the entity description ingame without this mod, and that description is missing/replaced because of the mod, it's an actual change of the item description. And not having informations about the placed entity in an item description, if they were there before, is basically the opposite of "extending" a description. I don't understand the dismissive answer.

Anyway, the issue isn't limited to entity-placing items. As I described before, the mod overwrites descriptions defined in locale files. You can easily reproduce the issue: Just make a simple mod that gives a description with a locale file (under "[item-description]") to any item that doesn't place an entity, e.g. an ammo item. That mod will only work if "Extended Descriptions" isn't active.

Or just check repair packs: Their vanilla description vanishes when using this mod.

As I tried to explain before: This mod sets the localised_description-field of items (in data-final-fixes.lua) which overwrites descriptions from locale files. In cases where that field had a value before, the code merges the values, but descriptions in locale files are never copied to it.

You are right about repair packs, but there is no other solution unless the api is changed

Hmm, yes, I think so to. I tried to fix the code myself, but basically you would have to include a reference in the localised description, e.g. somewhat like this:
prototype.localised_description = {'', {'item-description.'..prototype.name}, '\n', localised_string}

This works for items that actually have a description key in a locale file, but all items without a respective key (ergo most items) then show "Unknown key ..." in their description. The solution would propably be an API feature like discussed here: https://forums.factorio.com/viewtopic.php?f=28&p=575963.

So, at the moment, it seems there is no generic solution. But you could fix it for vanilla items: Just set the localised_description field of vanilla items that have a specific description to the correct key, before applying the current procedure in data-final-fixes.

And maybe the claims in the mod description (like "does not overwrite any existing descriptions" and "supports all mods") could be a bit more humble. ;)

Hi!

Factorio 1.1.73 adds a new feature which prevents overwriting existing descriptions.
https://forums.factorio.com/71553

I've implemented this into ED

Oh, nice. Thanks for implementing that.