Merging Chests Logistic

by Atria

Mod adding logistic variants of merged chests.

Content
22 days ago
1.1 - 2.0
13.7K
Storage

g Requester and buffer chests - logistic requests

6 days ago

Disabled state of logistic requests is not preserved when merging or splitting requesters of buffers.
If you split or merge these chest types and they have disabled logistic requests groups, after merge or split the group is enabled.

5 days ago

How would you propose this should work?

Right now during merge all requests are merged into new unnamed logistic group.
During split it depends on your mod settings, but it can either split whole requests, split requested counts or copy all requests among split chests. Again all of these are new unnamed logistic groups.

It would be simple to not merge logistic groups during merge (which would preserve if logistic group is enabled/disabled). But question is if there still should be some request merging done, because it would be annoying to have 10 logistic groups in one chest.
Also how would this work when splitting chests? If merged chest has one named logistic group and your mod setting is anything other than "Copy requests", the requests would have to be modified (either splitting requested items or splitting their counts).

5 days ago

You are absolutly right. I didn't though about the complexety of this "simple matter".
Seperate logistic groups would be really annoying. Merging unnamed groups - as it is right now - is the best way.
In general I think changing of any named groups - as they are defined globally - is not appropiate at all.

I guess thats really a thing of personal preference, but some ideas:

  1. For merging disabling the merged group if one of the source groups was disabled
  2. Dont touch named groups in general (always do "Copy requests" for named groups, maybe as a setting)
  3. Introduce a setting to always disable all requests on merge / split (keep all other current merge / split behaviour like it is)
  4. Setting to show a dialog on every split / merge (I chets with requests involved) and ask what to do (copy, split, disable requests, ...)

Number 3 would be fine for me, but maybe I would be the only user of that.
Number 4 would be really great I guess, but also comes with a bunch of work / coding.

I din't worked on any published mods for a couple of years now, but I think I could provide a PR for at least #3.

4 days ago
  1. If you mean that single logistic group should be disabled if any logistic groups were disabled then I don't agree. But grouping requests to "enabled" and "disabled" section sound good.
  2. Copying named groups to all split chests regardless of split mod setting would be incorrect behaviour IMO.
  3. Merging/splitting was designed to be as close to having side effects as possible.
  4. That's a definite no from me as it would be SUPER annoying, especially when merging large amount of chests in one go.

I would like to have same behaviour for merging and splitting (since that is how it is right now).

  • Merge requests in all enabled unnamed groups into one logistic group
  • Merge requests in all disabled unnamed groups into one logistic group
  • Depending on split mod setting:
  • If "Copy" then: apply all named groups and two groups from above to all chests
  • Else: include requests from named groups into two groups from above as well, then split requests accoding to mod setting

So only change would be to sort request into two groups based on if they come from enabled or disabled group.

I also could add support for quality, as right now only "equals normal" quality is supported

New response